improved read onlyness and constness #7394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badasahog
requested review from
HughParsonage,
MichaelChirico,
ben-schwen,
jangorecki and
tdhock
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7394 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 85 85
Lines 16610 16610
=======================================
Hits 16466 16466
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit cb5c837 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup on #7368
Increase in speed is minimal (if even existent), but this should hopefully improve readability.
Knowing ahead of time if an object will be modified could make the code more digestable.
There's still more ground to cover, but I'll wait for this pr to go through first.